[SECURITY] Implementasi & Perkuat Rate Limiting pada Semua Endpoint Kritis#972
Open
pandigresik wants to merge 2 commits intorilis-devfrom
Open
[SECURITY] Implementasi & Perkuat Rate Limiting pada Semua Endpoint Kritis#972pandigresik wants to merge 2 commits intorilis-devfrom
pandigresik wants to merge 2 commits intorilis-devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perbaikan issue #957
Peningkatan Keamanan: Pembatasan Kecepatan & Penguncian Akun
Ringkasan
Dokumen ini menjelaskan peningkatan keamanan yang telah diterapkan untuk mengatasi kerentanan brute-force dan DDoS pada aplikasi OpenKab.
Masalah yang Diselesaikan
false- Pembatasan kecepatan dinonaktifkan secara defaultSolusi yang Diterapkan
1. Mengaktifkan Pembatasan Kecepatan Global Secara Default
RATE_LIMITER_ENABLEDdarifalsemenjaditruedi.env.example2. Peningkatan Pembatasan Kecepatan dengan Sidik Jari Multi-Faktor
Pembatasan kecepatan sekarang menggabungkan:
Ini mencegah penghindaran melalui:
3. Mekanisme Penguncian Akun
Setelah beberapa kali percobaan login gagal:
4. Penundaan Bertahap
Setelah setiap percobaan gagal, penundaan eksponensial diterapkan:
base_delay × (multiplier ^ (attempts - 1))File yang Dimodifikasi
File Konfigurasi
.env.example- Menambahkan konfigurasi keamananconfig/app.php- Menambahkan konfigurasi penguncian dan penundaan bertahapconfig/rate-limiter.php- Sudah memiliki default yang benar (true)Database
database/migrations/2026_03_05_000001_add_account_lockout_to_users_table.php(BARU)failed_login_attemptslocked_atlockout_expires_atModel
app/Models/User.phpisLocked()getLockoutRemainingSeconds()recordFailedLogin()resetFailedLogins()lockAccount()danunlockAccount()Middleware
app/Http/Middleware/GlobalRateLimiter.phpresolveRequestSignature()dengan IP + User-Agent + ID PenggunafingerprintUserAgent()calculateProgressiveDelay()recordFailedAttempt()isLocked()clearFailedAttempts()Controller
app/Http/Controllers/Api/Auth/AuthController.phpthrottleKey()dengan IP + User-Agent + Kredensialapp/Http/Controllers/Auth/OtpLoginController.phpapp/Http/Controllers/OtpController.phpapp/Http/Controllers/TwoFactorController.phpOpsi Konfigurasi
Tambahkan ini ke file
.envAnda:Langkah-Langkah Penerapan
Backup database Anda
mysqldump -u root -p your_database > backup.sqlJalankan migrasi
Perbarui file .env
Salin nilai konfigurasi baru dari
.env.exampleke.envAndaBersihkan cache
Uji implementasi
Perubahan Respons API
Respons Login Gagal (dengan penundaan bertahap)
{ "message": "Kredensial tidak valid. Percobaan gagal ke-2. Delay: 4 detik.", "attempts_remaining": 3, "progressive_delay": 4 }Respons Akun Terkunci
{ "message": "AKUN TERKUNCI. Terlalu banyak gagal login (5 kali).", "locked": true, "lockout_expires_in": 900 }Respons Batas Kecepatan Terlampaui
{ "message": "TERLALU BANYAK PERCOBAAN. Silakan tunggu 10 menit sebelum mencoba lagi.", "retry_after": 600 }Manfaat Keamanan
Rekomendasi Pemantauan
failed_login_attemptsuntuk pola yang mencurigakanPengujian
Jalankan tes yang ada untuk memastikan kompatibilitas:
Referensi