Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #942
penyesuaian API https://github.com/OpenSID/API-Database-Gabungan/pull/332
Deskripsi Singkat
Pull request ini bertujuan untuk menampilkan artikel dari OpenSID ke halaman publik (depan) website OpenKab. Sebelumnya, artikel OpenSID sudah dikelola di bagian admin namun belum muncul bagi pengunjung website.
Perubahan Utama
ArtikelControllerbaru di namespaceWebuntuk melayani permintaan halaman daftar dan detail artikel OpenSID.ArtikelServicemengambil data agar menggunakan endpoint/api/v1/artikel/list. Saya juga menambahkan logika untuk memperkaya data artikel (menambahkan gambar dan isi) dengan mengambil detail tiap artikel secara otomatis.web/artikel/index.blade.php) untuk menampilkan semua berita terbaru.web/artikel/show.blade.php) untuk membaca isi lengkap berita.web/index.blade.php) menggunakan partial view yang memuat data secara cepat melalui AJAX.web.phpuntuk memetakan URL/artikel-opensidke fungsionalitas yang baru dibuat.tests/Feature/ArtikelWebTest.phpuntuk memastikan fitur ini berjalan aman dan benar.Cara Verifikasi
/artikel-opensiduntuk melihat daftar semua artikel.php artisan test --filter=ArtikelWebTest