Upgrade Boost from 1.78.0 to 1.87.0#176
Conversation
- Fixes MSVC C++20 typename bug in boost::process headers (fixed upstream in 1.82) - Boost.Process v1 shims still present in 1.87 (removed in 1.88+) - Remove hardcoded architecture=x86 from b2 build to support ARM64 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
365d33b to
c3b82fb
Compare
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request updates the Boost dependency references in CMake from boost-1.81.0 to boost-1.87.0 and adjusts the Boost archive filename and SHA256 checksum; it also contains minor whitespace/formatting changes in the Boost build command invocation within CMake macros. Changes
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
boost::processheaders (C7510, fixed upstream in Boost 1.82)architecture=x86from b2 build command to support ARM64 buildsMotivation
PR OpenMS/OpenMS#8939 replaces QProcess with boost::process. The old Boost 1.78 in contrib has a known typename bug that breaks MSVC C++20 strict mode. Upgrading to 1.87 fixes this without needing CI patches.
After merge
Trigger
workflow_dispatchon themain.ymlCI to rebuild and releasecontrib_build-*.tar.gzfor all platforms.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit