Conversation
wforney
commented
Sep 27, 2019
- Updated all projects to VS 2019, .NET Framework 4.8, and latest Windows 10 target for the C++ project
|
Hi @wforney, seems mostly solid. There are a few errors in the CI build as it's still running 2017, |
|
Hi @wforney, I found some docs which might help out; It might be worth changing the version specifier from |
There was a problem hiding this comment.
Pull request overview
This pull request updates the OpenLiveWriter project from Visual Studio 2017 to Visual Studio 2019, upgrades all .NET Framework projects from version 4.6.1/4.7.2 to 4.8, and updates the C++ project to use the latest Windows 10 SDK (10.0) with the v142 platform toolset.
Changes:
- Updated C++ project to use Windows SDK 10.0 and Visual Studio 2019 toolset (v142)
- Upgraded all managed projects to target .NET Framework 4.8
- Updated build infrastructure (build.ps1, appveyor.yml) to use Visual Studio 2019
- Updated test dependencies (NUnit 3.4.1→3.12.0, ApprovalTests 3.0.11→4.2.2)
Reviewed changes
Copilot reviewed 45 out of 48 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/unmanaged/OpenLiveWriter.Ribbon/OpenLiveWriter.Ribbon.vcxproj | Updated C++ project to Windows SDK 10.0 and v142 toolset |
| src/managed/writer.sln | Added build script references to solution items |
| src/managed/*/*.csproj (multiple) | Added TargetFrameworkVersion v4.8 to all managed projects |
| src/managed/*/app.config (multiple) | Updated supportedRuntime to .NET Framework 4.8 |
| src/managed/OpenLiveWriter.Tests/packages.config | Updated NUnit and ApprovalTests packages to newer versions |
| build.ps1 | Updated build script for VS 2019 (MSBuild path and error messages) |
| appveyor.yml | Changed build image from VS 2017 to VS 2019 |
| src/managed/LocEdit/Properties/*.Designer.cs | Auto-generated code updated to VS 2019 tooling version |
Files not reviewed (3)
- src/managed/LocEdit/Properties/Resources.Designer.cs: Language not supported
- src/managed/LocEdit/Properties/Settings.Designer.cs: Language not supported
- src/managed/OpenLiveWriter.Localization/Images.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* upstream/master: Address PR feedback: fix block-level elements closing P and nested containers Fix artifact path: upload binaries instead of releases folder Fix GitHub Actions build: add .NET 4.6.1 dev pack and VS2022 compatibility Add GitHub Actions CI workflow Add VS2026 support and make toolset selection flexible Update build scripts and C++ project for VS2019/VS2022 compatibility tests: Add unit tests for HtmlUtils.NormalizeHtmlClosingTags Fix paste to normalize HTML closing tags Add NormalizeHtmlClosingTags method to ensure optional-end-tag elements have closing tags Remove vscode settings.json openlivewriter.org => openlivewriter.org, see OpenLiveWriter#911 Switch Default Blog endpoints to SSL src/unmanaged/OpenLiveWriter.Ribbon/OpenLiveWriter.Ribbon.vcxproj src/managed/OpenLiveWriter.BlogClient/Providers/BlogProviders.xml src/managed/OpenLiveWriter.HtmlEditor/Linking/GlossaryManager.cs src/managed/OpenLiveWriter.HtmlEditor/Marshalling/Data_Handlers/HtmlHandler.cs src/managed/OpenLiveWriter.Tests/HtmlParser/HtmlNormalizationTests.cs src/unmanaged/OpenLiveWriter.Ribbon/OpenLiveWriter.Ribbon.vcxproj
Updated all app.config files to use tabs instead of spaces for XML indentation. No configuration values or binding redirects were changed; only formatting was improved for consistency and readability.