Merged
Conversation
nan-li
force-pushed
the
feat/disable_swizzling_option
branch
from
3e44488 to
e356949
Compare
- Added APIs for manual notification handling and lifecycle observation when swizzling is disabled. - Introduced a new constant for controlling swizzling via Info.plist.
nan-li
force-pushed
the
feat/disable_swizzling_option
branch
from
e356949 to
81fbfe7
Compare
| + (BOOL)isSwizzlingDisabled { | ||
| static BOOL _cached = NO; | ||
| static BOOL _disabled = NO; | ||
| if (!_cached) { |
Contributor
There was a problem hiding this comment.
how is this protected from multiple threads accessing this method?
Contributor
Author
There was a problem hiding this comment.
Good point, will address, but two threads could both see _cached == NO and both compute the value. In practice it's harmless since the plist value is immutable and both threads would write the same result, but it's not good practice
abdulraqeeb33
approved these changes
Mar 6, 2026
| + (BOOL)isSwizzlingDisabled { | ||
| static BOOL _disabled = NO; | ||
| static dispatch_once_t onceToken; | ||
| dispatch_once(&onceToken, ^{ |
* thread safety * rename a method for clarity
minimum is ios 12
nan-li
force-pushed
the
feat/disable_swizzling_option
branch
from
36118ce to
f5b9997
Compare
Merged
This was referenced Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add option to disable swizzling and add manual integration APIs, when disabled.
Details
Motivation
Allow disabling swizzling for developers to have more control over notification delegate methods.
New Manual Integration APIs
If swizzling is enabled but the new forwarding APIs are used, those APIs would no-op and log a warning.
All new manual integration APIs are called on the
OneSignal.Notifications namespace:How to test
Commit dev app: setup to test swizzle disabled is setup to allow testing
Scope
Swizzling disable option
Testing
Unit testing
None
Manual testing
iPhone on iOS 26.3 with sizzling disabled via Info.plist for:
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is