Skip to content

use uris instead of hostname and port#8

Open
matheusfillipe wants to merge 1 commit intomainfrom
feat/support-ircs-changeschema
Open

use uris instead of hostname and port#8
matheusfillipe wants to merge 1 commit intomainfrom
feat/support-ircs-changeschema

Conversation

@matheusfillipe
Copy link
Contributor

@matheusfillipe matheusfillipe commented Feb 24, 2026

Summary by CodeRabbit

  • Chores
    • Updated network configuration to use secure connection protocols (WebSocket Secure and IRC Secure) across all supported networks, replacing legacy connection methods.

Needed for ObsidianIRC/ObsidianIRC#149

This is a breaking change that will break outdated obsidians.... but I think is a better schema and better way to proceed and not break it again in the future.

@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c67ddf7 and cdde563.

📒 Files selected for processing (1)
  • servers.json

📝 Walkthrough

Walkthrough

The servers.json configuration file has been restructured to replace simple server and port fields with dedicated secure connection specifications (wss for WebSocket Secure and ircs for IRC Secure), each containing their own host and port values.

Changes

Cohort / File(s) Summary
Configuration Update
servers.json
Migrated per-network connection fields from server/port to separate wss and ircs objects, each with dedicated host and port properties for secure protocol variants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The servers dance in new attire,
With wss and ircs secure and dire,
Old fields fade to yesterday's plight,
While encryption keeps the rabbits safe and bright! 🔐✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing hostname and port fields with URIs (wss and ircs fields) across all network entries in servers.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/support-ircs-changeschema

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant