refactor(convert): dynamically detect languages and versions instead …#2359
Open
Arunodoy18 wants to merge 2 commits intoOWASP:masterfrom
Open
refactor(convert): dynamically detect languages and versions instead …#2359Arunodoy18 wants to merge 2 commits intoOWASP:masterfrom
Arunodoy18 wants to merge 2 commits intoOWASP:masterfrom
Conversation
…of hardcoded lists (fixes OWASP#2340)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
ConvertVarsto dynamically detect available languages and versions by scanning thesource/directory at runtime instead of relying on hardcoded lists.Closes #2340.
Problem
ConvertVarspreviously used hardcoded LANGUAGE_CHOICES and VERSION_CHOICES.This required manual updates whenever new YAML files were added and created a risk of inconsistencies between the script and the actual contents of
source/.Changes
source/directory for.yamlfiles during initialization.Benefits
Notes