fix: normalize Table10/Table11 row heights in guide templates#2337
Open
Arunodoy18 wants to merge 1 commit intoOWASP:masterfrom
Open
fix: normalize Table10/Table11 row heights in guide templates#2337Arunodoy18 wants to merge 1 commit intoOWASP:masterfrom
Arunodoy18 wants to merge 1 commit intoOWASP:masterfrom
Conversation
Fixes OWASP#2133 Problem: The first suit table (VE - Data Validation & Encoding) in both guide template variants had inconsistent row heights compared to all other suit tables, causing text overflow in translations with longer content. Standard template (owasp_cornucopia_webapp_ver_guide_bridge_lang.odt): - Table10.2: 3.501cm (should be 4.001cm) - Table10.3: 4.501cm (should be 4.001cm) QR template (owasp_cornucopia_webapp_ver_guide_bridge_qr_lang.odt): - Table11.4: 3.501cm (should be 4.001cm) All other suit tables (17/18 through 87/95) use 4.001cm uniformly. Solution: Normalized the inconsistent row heights to 4.001cm to match the standard used by all other suit tables. This provides consistent vertical spacing across all card descriptions and prevents text overflow issues in non-English translations. Changes: - Fixed row heights in both guide template variants - Added fix_templates_issue_2133.py script for reproducibility - Updated .gitignore to exclude .backup files
Arunodoy18
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
Collaborator
|
@Arunodoy18 Thank you for this. Make sure your commits are signed with a valid signature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2133
Problem:
The first suit table (VE - Data Validation & Encoding) in both guide template variants had inconsistent row heights compared to all other suit tables, causing text overflow in translations with longer content.
Standard template (owasp_cornucopia_webapp_ver_guide_bridge_lang.odt):
QR template (owasp_cornucopia_webapp_ver_guide_bridge_qr_lang.odt):
All other suit tables (17/18 through 87/95) use 4.001cm uniformly.
Solution:
Normalized the inconsistent row heights to 4.001cm to match the standard used by all other suit tables. This provides consistent vertical spacing across all card descriptions and prevents text overflow issues in non-English translations.
Changes: