Skip to content

Comments

Add framed privacy notices to game and player forms#2262

Draft
Adarshkumar0509 wants to merge 3 commits intoOWASP:masterfrom
Adarshkumar0509:feature/privacy-notice-game-player-forms
Draft

Add framed privacy notices to game and player forms#2262
Adarshkumar0509 wants to merge 3 commits intoOWASP:masterfrom
Adarshkumar0509:feature/privacy-notice-game-player-forms

Conversation

@Adarshkumar0509
Copy link

Summary

  • Adds a framed privacy notice below the game form.
  • Adds a framed privacy notice below the player form.
  • Uses the exact wording suggested in the issue discussion.
  • Does not change any existing workflows or validation logic.

Notice text
Please note: Avoid submitting sensitive and/or personal information to minimize the risk of data exfiltration due to accidental data exposure.

Scope
This PR intentionally only implements the “warning first” approach discussed in the comments, by adding the framed notices to both forms. It does not yet implement:

  • The fixed list of 82 character names
  • Random assignment of player names
  • Random game names

I’m happy to help with the random name functionality as a follow-up if you’d like and once the design is agreed.

Fixes #1909

@sydseter
Copy link
Collaborator

Hi, I am unable to see the message.

@sydseter
Copy link
Collaborator

copi.owasp.org/lib/copi_web/live/player_live/form_component.html.heex

is a former template that isn't used anymore, can you remove it?

Use this instead:

copi.owasp.org\lib\copi_web\live\player_live\form_component.ex

@sydseter
Copy link
Collaborator

We need a notice as well on the game name input.

@Adarshkumar0509
Copy link
Author

Updated to use form_component.ex and removed the old .html.heex template. The framed privacy notice now appears below the player form (and I can add the same for the game form similarly).

@sydseter
Copy link
Collaborator

The build is failing. I believe you have an issue with the Phoenix template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Privacy improvements: Replace player name and game name fields

2 participants