Add framed privacy notices to game and player forms#2262
Draft
Adarshkumar0509 wants to merge 3 commits intoOWASP:masterfrom
Draft
Add framed privacy notices to game and player forms#2262Adarshkumar0509 wants to merge 3 commits intoOWASP:masterfrom
Adarshkumar0509 wants to merge 3 commits intoOWASP:masterfrom
Conversation
Collaborator
|
Hi, I am unable to see the message. |
Collaborator
|
copi.owasp.org/lib/copi_web/live/player_live/form_component.html.heex is a former template that isn't used anymore, can you remove it? Use this instead: copi.owasp.org\lib\copi_web\live\player_live\form_component.ex |
Collaborator
|
We need a notice as well on the game name input. |
Author
|
Updated to use form_component.ex and removed the old .html.heex template. The framed privacy notice now appears below the player form (and I can add the same for the game form similarly). |
Collaborator
|
The build is failing. I believe you have an issue with the Phoenix template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notice text
Please note: Avoid submitting sensitive and/or personal information to minimize the risk of data exfiltration due to accidental data exposure.
Scope
This PR intentionally only implements the “warning first” approach discussed in the comments, by adding the framed notices to both forms. It does not yet implement:
I’m happy to help with the random name functionality as a follow-up if you’d like and once the design is agreed.
Fixes #1909