Introduce CliArgs (new design) and use to further generalize ThreeBusBasicJson example#341
Draft
PhilipFackler wants to merge 2 commits intodevelopfrom
Draft
Introduce CliArgs (new design) and use to further generalize ThreeBusBasicJson example#341PhilipFackler wants to merge 2 commits intodevelopfrom
CliArgs (new design) and use to further generalize ThreeBusBasicJson example#341PhilipFackler wants to merge 2 commits intodevelopfrom
Conversation
pelesh
reviewed
Feb 24, 2026
Collaborator
pelesh
left a comment
There was a problem hiding this comment.
This is very welcome and long overdue update. Thanks for taking initiative on this. A few comments:
- Please document new functions with more detailed comments in the code.
- Consider separate source/header files for different classes. Some of the classes are only a few rows but it might be a good idea to stick to "one class per file" rule.
- I made some style suggestions that clang-format will not fix.
Comment on lines
+16
to
+19
| class ArgValue | ||
| { | ||
| public: | ||
| ArgValue() = default; |
Collaborator
There was a problem hiding this comment.
I suggest we put classes ArgValue and ArgVector in separate header and source files.
216b243 to
7e50d41
Compare
7e50d41 to
326c561
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is another step toward a generalized application to replace examples.
Proposed changes
Use a new class
CliArgsto easily define command line options.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Note that this is a draft PR. I wanted to get feedback on the design of
CliArgs, and (if we want to keep it) I need to add documentation and testing for it. I would also add the capability to handle positional arguments.