Open
Conversation
mathben
force-pushed
the
18.0-mig-website_event_require_login
branch
from
53b1e1f to
98b188e
Compare
mathben
changed the title
mathben
force-pushed
the
18.0-mig-website_event_require_login
branch
from
98b188e to
317d3f4
Compare
Author
|
I edit multiple time, it was more simple to store into HTML if need require_login, and change Javascript flow. |
mathben
force-pushed
the
18.0-mig-website_event_require_login
branch
2 times, most recently
from
57316dd to
eb885f9
Compare
Author
|
I begin to write test with a GPT I test manually multiple case (with/without option, with public/connected user). |
TuxLeGrand
approved these changes
Mar 1, 2026
TuxLeGrand
left a comment
TuxLeGrand
left a comment
There was a problem hiding this comment.
It's working fine on my server with Odoo 18
mathben
changed the title
mathben
force-pushed
the
18.0-mig-website_event_require_login
branch
4 times, most recently
from
a6d8e31 to
c449cba
Compare
Author
|
Would you like to review my PR please @FrancoMaxime @pilarvargas-tecnativa |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-12.0/event-12.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-website_event_require_login/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-12.0/event-12.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-website_event_require_login/
[UPD] Update website_event_require_login.pot [UPD] README.rst
Wrong call of render_template() . _render_template() converted a private function in standard Odoo v14.
Currently translated at 100.0% (8 of 8 strings) Translation: event-16.0/event-16.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-website_event_require_login/it/
Currently translated at 100.0% (8 of 8 strings) Translation: event-16.0/event-16.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-website_event_require_login/es/
Currently translated at 100.0% (8 of 8 strings) Translation: event-16.0/event-16.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-website_event_require_login/it/
Currently translated at 100.0% (8 of 8 strings) Translation: event-16.0/event-16.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-website_event_require_login/it/
Currently translated at 100.0% (8 of 8 strings) Translation: event-16.0/event-16.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-website_event_require_login/ca/
Currently translated at 100.0% (8 of 8 strings) Translation: event-16.0/event-16.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-website_event_require_login/de/
Currently translated at 100.0% (8 of 8 strings) Translation: event-16.0/event-16.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-website_event_require_login/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-16.0/event-16.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-website_event_require_login/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-17.0/event-17.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-17-0/event-17-0-website_event_require_login/
Currently translated at 100.0% (7 of 7 strings) Translation: event-17.0/event-17.0-website_event_require_login Translate-URL: https://translation.odoo-community.org/projects/event-17-0/event-17-0-website_event_require_login/fi/
mathben
force-pushed
the
18.0-mig-website_event_require_login
branch
from
c449cba to
c9dc7d9
Compare
pilarvargas-tecnativa
suggested changes
Mar 2, 2026
Contributor
pilarvargas-tecnativa
left a comment
pilarvargas-tecnativa
left a comment
There was a problem hiding this comment.
Hello, thank you for your work. All changes incorporated into the migration should go into the migration commit with the tag [MIG].
- README.md update website_event_require_login - patch EventRegistrationForm onClick - add data require-login into form registration - remove registration flow modal when detect registration require from Javascript - add contributor TechnoLibre tests ui with tours - test website_event_require_login_public - test website_event_require_login_auth
mathben
force-pushed
the
18.0-mig-website_event_require_login
branch
from
c9dc7d9 to
005f73d
Compare
Author
|
@pilarvargas-tecnativa |
mmaanneell
reviewed
Mar 10, 2026
mmaanneell
left a comment
mmaanneell
left a comment
There was a problem hiding this comment.
I tested it on Odoo 18. The checkbox works on the event form. Unauthenticated user gets the "Login required" modal and authenticated user gets the normal registration form. Works great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take module from https://github.com/OCA/event/tree/17.0/website_event_require_login, apply OCA migration script and fix the Javascript.
The Javascript from Odoo 17
https://github.com/odoo/odoo/blob/17.0/addons/website_event/static/src/js/website_event.js#L68
is different from Odoo 18
https://github.com/odoo/odoo/blob/18.0/addons/website_event/static/src/js/website_event.js#L72
When detect require_login, cancel the website_event javascript _onClick and show modal.