[18.0][FIX] donation: fix partner donation count always showing 0#153
Open
dbruehlmeier wants to merge 1 commit intoOCA:18.0from
Open
[18.0][FIX] donation: fix partner donation count always showing 0#153dbruehlmeier wants to merge 1 commit intoOCA:18.0from
dbruehlmeier wants to merge 1 commit intoOCA:18.0from
Conversation
In Odoo 18.0, _read_group() returns recordsets as group keys, not integer IDs. The mapped_data dictionary was keyed by res.partner records but the lookup used partner.id (an integer), causing the count to always resolve to the default value of 0.
Contributor
|
Hi @alexis-via, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
donation_countsmart button on the partner form always displaying 0, even when the partner has confirmed donations.Root Cause
In Odoo 18.0,
_read_group()returns recordsets as group keys, not integer IDs. Themapped_datadictionary in_compute_donation_countwas keyed byres.partnerrecord objects, but the subsequent lookup usedpartner.id(an integer). Since a record object never equals an integer,.get(partner.id, 0)always fell through to the default0.Fix
Use
partner.idas the dictionary key when buildingmapped_dataso the lookup types match.