Skip to content

[18.0][IMP] agreement_legal: refactor agreement form to inherit base view#101

Open
MohamedOsman7 wants to merge 1 commit intoOCA:18.0from
c4a8-odoo:18.0-imp-agreement_legal
Open

[18.0][IMP] agreement_legal: refactor agreement form to inherit base view#101
MohamedOsman7 wants to merge 1 commit intoOCA:18.0from
c4a8-odoo:18.0-imp-agreement_legal

Conversation

@MohamedOsman7
Copy link

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @max3903, @ygol,
some modules you are maintaining are being modified, check this out!

@MohamedOsman7 MohamedOsman7 marked this pull request as draft January 26, 2026 10:04
@MohamedOsman7 MohamedOsman7 force-pushed the 18.0-imp-agreement_legal branch from 924dcd4 to fec71e5 Compare January 26, 2026 10:24
@CRogos CRogos force-pushed the 18.0-imp-agreement_legal branch from ac33e5e to 78de6c9 Compare February 9, 2026 11:07
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, replacement < inheritance

@tarteo
Copy link
Member

tarteo commented Feb 27, 2026

@max3903 @ygol @leemannd @rvalyi Can you review this? If this is merged we can also change the dependency from agreement_legal to agreement in agreement_project

Copy link
Contributor

@ygol ygol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@MohamedOsman7
Copy link
Author

@leemannd Could you merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants