Bugfix/resolving dependency issue due to conflict between vertx classpaths#201
Open
shishir-lab wants to merge 1 commit intomasterfrom
Open
Bugfix/resolving dependency issue due to conflict between vertx classpaths#201shishir-lab wants to merge 1 commit intomasterfrom
shishir-lab wants to merge 1 commit intomasterfrom
Conversation
…h and isolated classpath and used deployment options to resolve such cases.
Contributor
|
I have not yet had time to do review, but it is quite correct direction. |
f2047b4 to
68d3fa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #196 , the issue #141 is resolved by sending deployment options with isolated classes in the app config.
With this approach, the modules/services should pass additional appConfig as shown below if the module/service has issue related with class not found.