Conversation
b3cdd74 to
44b2478
Compare
clis/nordvpnlite/openwrt/feed/net/nordvpnlite/files/luci/ucode/nordvpnlite.uc
Show resolved
Hide resolved
clis/nordvpnlite/openwrt/feed/net/nordvpnlite/files/luci/ucode/nordvpnlite.uc
Outdated
Show resolved
Hide resolved
clis/nordvpnlite/openwrt/feed/net/nordvpnlite/files/luci/view/nordvpnlite/settings.js
Show resolved
Hide resolved
|
I successfully edited the config file, yet had no way to start the daemon from UI. This left me to go through cli to achieve that. Would it be possible to do an implicit restart or maybe have a separate button for that in the UI? |
There are separate tickets for that |
That's fine, could you point the ticket out to me? |
LLT-7057 |
|
+1 looks good |
44b2478 to
f40c267
Compare
f40c267 to
a679db6
Compare
a679db6 to
0fe2fed
Compare
0fe2fed to
ac4f08d
Compare
ac4f08d to
3d64278
Compare
| ui.addNotification(_('Save failed'), E('p', err ? String(err) : _('Unknown error'))); | ||
| } | ||
|
|
||
| return callSetConfig(config); |
There was a problem hiding this comment.
Should it be this.config instead of config? Also callSetConfig is called already so this invocation looks unnecessary
There was a problem hiding this comment.
This is some garbage, don't know how it happened :D Thanks
| return m.render(); | ||
| }, | ||
|
|
||
| handleSave: async function () { |
There was a problem hiding this comment.
handleSave doesn't seem to do input validation so I can leave a single letter country-code and it will be saved to the config file even though UI hints that it's invalid value.
If it is supposed to validate then the following can be done:
- in
renderstore theform.JSONMapasthis.map = m; - in
handleSave
return this.map.parse().then(
() => {
// validation passed
},
(err) => {
ui.addNotification("parse", `error: ${err}`);
throw err;
}
); Allows for setting authentication_token and vpn in nordvpnlite configuration file.
3d64278 to
fb38b2d
Compare
Allows for setting authentication_token and vpn in nordvpnlite configuration file.
☑️ Definition of Done checklist