Skip to content

LLT-6720 OpenWrt UI MVP#1678

Open
jjanowsk wants to merge 1 commit intomainfrom
LLT-6720-openwrt-ui
Open

LLT-6720 OpenWrt UI MVP#1678
jjanowsk wants to merge 1 commit intomainfrom
LLT-6720-openwrt-ui

Conversation

@jjanowsk
Copy link
Collaborator

@jjanowsk jjanowsk commented Feb 11, 2026

Allows for setting authentication_token and vpn in nordvpnlite configuration file.

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@jjanowsk jjanowsk requested a review from a team as a code owner February 11, 2026 07:06
@jjanowsk jjanowsk force-pushed the LLT-6720-openwrt-ui branch from b3cdd74 to 44b2478 Compare February 11, 2026 10:00
@LukasPukenis
Copy link
Collaborator

LukasPukenis commented Feb 12, 2026

I successfully edited the config file, yet had no way to start the daemon from UI. This left me to go through cli to achieve that.

Would it be possible to do an implicit restart or maybe have a separate button for that in the UI?

@jjanowsk
Copy link
Collaborator Author

I successfully edited the config file, yet had no way to start the daemon from UI. This left me to go through cli to achieve that.

Would it be possible to do an implicit restart or maybe have a separate button for that in the UI?

There are separate tickets for that

@LukasPukenis
Copy link
Collaborator

LukasPukenis commented Feb 17, 2026

There are separate tickets for that

That's fine, could you point the ticket out to me?

@jjanowsk
Copy link
Collaborator Author

There are separate tickets for that

That's fine, could you point the ticket out to me?

LLT-7057

@LukasPukenis
Copy link
Collaborator

+1 looks good

Copy link
Contributor

@tomaszklak tomaszklak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+0.5

ui.addNotification(_('Save failed'), E('p', err ? String(err) : _('Unknown error')));
}

return callSetConfig(config);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be this.config instead of config? Also callSetConfig is called already so this invocation looks unnecessary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some garbage, don't know how it happened :D Thanks

return m.render();
},

handleSave: async function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleSave doesn't seem to do input validation so I can leave a single letter country-code and it will be saved to the config file even though UI hints that it's invalid value.

If it is supposed to validate then the following can be done:

  1. in render store the form.JSONMap as this.map = m;
  2. in handleSave
return this.map.parse().then(                                                                  
    () => {
       // validation passed
    },
    (err) => {
        ui.addNotification("parse", `error: ${err}`);
        throw err;
     }
  );   

Allows for setting authentication_token and vpn in nordvpnlite
configuration file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants