Merged
Conversation
… changed in 3.14 in get_type_hint_args(), get_type_hint_parameters() and get_type_hint_origin()
… attribute on types directly and supports calling the `__annotate__()` function
…tly different result in 3.14
NiklasRosenstein
force-pushed
the
nr/py-3.14-support
branch
from
7f49423 to
62fca7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.14 had some bigger changes with regards to annotations.
Most prominently that all annotations are evaluated lazily now (
from __future__ import annotationsis now the standard), although that should not have been an issue fortypeapibecause it was already able to deal with this.However, some API changes regarding annotation types in 3.14 have been causing issues, such as
Generic.__origion__(the attribute of the class directly) is now a descriptor instead of referencing itself.Python 3.14 also introduced the
annotationlibwhich this PR begins to make use of as well as an__annotate__()method that ourget_annotations()backport now calls.