Fix #66: dataclass from Generic now serializes#78
Merged
NiklasRosenstein merged 7 commits intodevelopfrom Mar 25, 2026
Merged
Conversation
Co-authored-by: Niklas Rosenstein <rosensteinniklas@gmail.com>
Adds a `seen` set to avoid processing the same base type twice when iterating both hint.bases and hint.type.__bases__. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #68 (which was accidentally closed).
Summary
Generic[T]without parameterizing it (e.g.class B(A)instead ofclass B(A[T])), serialization/deserialization was dropping the parent's fields.hint.bases or hint.type.__bases__short-circuits —hint.basescontainsGeneric[T](not the actual parent), so__bases__was never consulted.(*hint.bases, *hint.type.__bases__)with deduplication via aseenset.Changes
databind/core/schema.py: iterate both base sources with dedupdatabind/core/tests/schema_test.py: schema-level regression testdatabind/json/tests/converters_test.py: serialize + deserialize regression test.changelog/_unreleased.toml: changelog entryOriginal author: @rhaps0dy
🤖 Generated with Claude Code