Skip to content

Change NREL to NLR#492

Open
martin-springer wants to merge 4 commits intomigrate-to-pyproject-tomlfrom
migrate-NREL-to-NatLabRockies
Open

Change NREL to NLR#492
martin-springer wants to merge 4 commits intomigrate-to-pyproject-tomlfrom
migrate-NREL-to-NatLabRockies

Conversation

@martin-springer
Copy link
Collaborator

@martin-springer martin-springer commented Mar 6, 2026

Update GitHub URLs and references from NREL to NatLabRockies

Updates all GitHub URLs from NREL/rdtools to NatLabRockies/rdtools and email addresses from @nrel.gov to @nlr.gov across the repository. Also updates the org name reference from "NREL" to "NLR" in comments and changelogs. Dataset proper names (e.g., NREL PVDAQ) and GitHub usernames (e.g., kanderso-nrel) are left unchanged.

Files changed

  • pyproject.toml — project URLs
  • README.md — badges, citation, and wiki link
  • CITATION.cff — repository URL
  • CODE_OF_CONDUCT.md — contact email
  • rdtools/soiling.py — issue links in warnings
  • rdtools/test/soiling_test.py — issue link in docstring
  • rdtools/test/filtering_test.py — location comment
  • docs/sphinx/source/conf.py — extlinks and source URL
  • docs/sphinx/source/index.rst — citation and link targets
  • docs/sphinx/source/developer_notes.rst — clone URL
  • docs/sphinx/source/changelog/v2.0.0.rst — campus name
  • docs/sphinx/source/changelog/pending.rst — changelog entry

Closes

Checklist

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.82%. Comparing base (77e8bd8) to head (cadebc6).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           migrate-to-pyproject-toml     #492   +/-   ##
==========================================================
  Coverage                      96.82%   96.82%           
==========================================================
  Files                             12       12           
  Lines                           2332     2332           
==========================================================
  Hits                            2258     2258           
  Misses                            74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwhanse
Copy link
Contributor

cwhanse commented Mar 6, 2026

@martin-springer because we are having a bit of a discussion on this in pvlib, is rdtools keeping e.g. "NREL TMY3", "NREL SPA" or are these being renamed to NLR?

@martin-springer
Copy link
Collaborator Author

@martin-springer because we are having a bit of a discussion on this in pvlib, is rdtools keeping e.g. "NREL TMY3", "NREL SPA" or are these being renamed to NLR?

@cwhanse - good question. I've only left one reference to NREL (for now) in rdtools and that is for a PVDAQ dataset that used an NREL site and was previously published. I wanted to get @mdeceglie opinion, before making the change to NLR for that reference.

Looking at this webpage https://midcdmz.nrel.gov/spa/ it seems like NREL SPA got already renamed into NLR SPA. I think, over the long run, we'll be replacing NREL entirely with NLR - especially since the nrel.gov domain will go away rather soon.

@cwhanse
Copy link
Contributor

cwhanse commented Mar 6, 2026

Thanks for helping to calibrate our thinking. We (pvlib maintainers) are inclined to leave "NREL" in bibliographic information, e.g., NREL Technical Report, since the report lists "NREL" as the publisher and changing to "NLR Technical Report" risks future "typo" issues. We're divided on the renaming of "NREL SPA".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants