Fix broad except ValueError in degradation_timeseries_plot for multi-YoY detection#490
Merged
cdeline merged 2 commits intodevelopmentfrom Mar 6, 2026
Merged
Fix broad except ValueError in degradation_timeseries_plot for multi-YoY detection#490cdeline merged 2 commits intodevelopmentfrom
except ValueError in degradation_timeseries_plot for multi-YoY detection#490cdeline merged 2 commits intodevelopmentfrom
Conversation
…n degradation_timeseries_plot Co-authored-by: cdeline <23244088+cdeline@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on Release 3.2.0 PR
Fix broad Mar 5, 2026
except ValueError in degradation_timeseries_plot for multi-YoY detection
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #490 +/- ##
============================================
Coverage 96.90% 96.90%
============================================
Files 12 12
Lines 2328 2329 +1
============================================
+ Hits 2256 2257 +1
Misses 72 72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdeline
approved these changes
Mar 6, 2026
Collaborator
cdeline
left a comment
There was a problem hiding this comment.
LGTM. Tested in the multi-YoY notebook and this explicit check for duplicate indices works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multi-YoY duplicate-timestamp case was detected by catching a broad
ValueErrorfrom.rolling(), which also fires for non-monotonic indexes — masking unrelated errors and potentially failing if the input is unsorted.Changes
rdtools/plotting.py—degradation_timeseries_plot:results_values.sort_index()before rolling so unsorted datetime indexes never raiseValueErrortry/except ValueErrorwith explicitresults_values.index.has_duplicatescheck; warning and daily resample only trigger when duplicate timestamps actually existChecklist
__init__.py💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.