Skip to content

openstudio-standards update to 0.8.5 bug fix version#456

Open
mdahlhausen wants to merge 13 commits intomainfrom
openstudio-standards_085_fixes
Open

openstudio-standards update to 0.8.5 bug fix version#456
mdahlhausen wants to merge 13 commits intomainfrom
openstudio-standards_085_fixes

Conversation

@mdahlhausen
Copy link
Contributor

@mdahlhausen mdahlhausen commented Mar 16, 2026

Pull request overview

  • This PR updates ComStock to use a (bug fix version of openstudio-standards 0.8.5)[https://github.com/NatLabRockies/openstudio-standards/commit/b0e4e42123b2530f7b1dc8697de1d765a1f4b5f3]
  • It includes updates to postprocessing in Postprocessing update #455
  • Change Doc

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Workflow Measures
  • Upgrade Measures
  • Postprocessing

Pull Request Author Checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Updated measure .xml(s)
  • Ran 10k+ test run and checked failure rate to make sure no new errors were introduced
  • Measure documentation written or updated

Pull Request Reviewer Checklist:

  • Perform a code review on GitHub
  • .yml and README.md files updated
  • Author had ensured all modified and new functions have docstrings
  • All changes have been implemented: data, methods, tests, documentation
  • (when CI works) Confirm no additional rubocop errors
  • Check edited measure .xml files updated
  • (when CI works) CI status: all tests pass
  • ComStock documentation adequately describes the new assumptions
  • Reviewed change documentation, results differences are reasonable, and no new errors introduced
  • Author has addressed comments in change documentation

update space_type_apply_internal_loads method call to use keyword arguments in 0.8.5
- replace std.ems_friendly_name with OpenstudioStandards::HVAC.ems_friendly_name. Called in facult_hvac_economizer_damper_stuck, upgrade_advanced_rtu_control, and upgrade_hvac_economizer measures
@mdahlhausen mdahlhausen added infrastructure PR improves or updates the build process and dependencies workflow measure PR improves or adds baseline workflow measures upgrade measure PR improves or adds upgrade measures labels Mar 16, 2026
use special branch of openstudio-standards
remove the set exterior lighting template measure from the sampling, workflow, and options lookup.tsv. Update the documentation to reflect the new exterior lighting assumptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure PR improves or updates the build process and dependencies upgrade measure PR improves or adds upgrade measures workflow measure PR improves or adds baseline workflow measures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant