fix bunch of compiler warnings and notices.#406
Open
fujitatomoya wants to merge 1 commit intoNVIDIA:masterfrom
Open
fix bunch of compiler warnings and notices.#406fujitatomoya wants to merge 1 commit intoNVIDIA:masterfrom
fujitatomoya wants to merge 1 commit intoNVIDIA:masterfrom
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
fujitatomoya
commented
Mar 1, 2026
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
i believe most of them are trivial warnings that we could just ignore. but since those are examples that users might copy&paste the code, it would be nicer to harden them without warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i was walking through the entire examples to learn basics, then i found those compile warnings.
make-after.log
make-before.log
with this PR,
python3 run_tests.py --output ./test --dir ./build/Samples --config test_args.json