refactor(tests): replace exec() with importlib in example runner#1628
Open
OfficialSerge wants to merge 1 commit intoNVIDIA:mainfrom
Open
refactor(tests): replace exec() with importlib in example runner#1628OfficialSerge wants to merge 1 commit intoNVIDIA:mainfrom
OfficialSerge wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is in response to the following TODO item in
cuda_core/tests/example_tests/utils.py.Key Changes
run_exampleinutils.pyusingimportlib, adding support for bothmain()andexec()scripts, tracebacks should now provide real line number feedback, thus paving the way for us to progressively enhance the remaining non-module tests and examples.test_basic_example.pyto usepathlib.Pathinstead ofos.path.join().Device(0)andset_current()calls in test class, instead relying on exitingdeinit_cuda()fixture for consistent teardowns (seeconftest.py)Next Steps
main()and refactor them into Python modules, some examples are currently refactored while others are still plain executables so it's a mix.