Allow StridedMemoryView to be constructed from dlpacks type code#1623
Draft
isVoid wants to merge 2 commits intoNVIDIA:mainfrom
Draft
Allow StridedMemoryView to be constructed from dlpacks type code#1623isVoid wants to merge 2 commits intoNVIDIA:mainfrom
StridedMemoryView to be constructed from dlpacks type code#1623isVoid wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
isVoid
changed the title
StridedMemoryView to be constructed from dlpacks type code/home/wangm/.pixi/bin/pixi shell --manifest-path /home/wangm/numba-cuda-fp8/pixi.toml --environment cu-13-0-py312StridedMemoryView to be constructed from dlpacks type code
isVoid
commented
Feb 13, 2026
| ], | ||
| ) | ||
| @pytest.mark.skipif(torch is None, reason="PyTorch is not installed") | ||
| def test_ml_dtypes_bfloat16_torch_dlpack(init_cuda, slices): |
Contributor
Author
There was a problem hiding this comment.
This tests interop between pytorch tensor, it passes for me locally. But would require adding torch into test environment. Should we do that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #1624
Patched dtype handler in
_memoryview.pyxto handle dlpack type code of kDLBfloat. Added tests to construct from an external object (currently, cupy) can communicate via dlpack bfloat16 type code.ml_dtypesis added as an optional dependency, whenml_dtypesisn't present, this code path should gracefully raise with readable error.Note: this still depends on an unreleased build of cupy. cupy/cupy#9670
Checklist