Skip to content

Make pathfinder INFO line counting non-failing unconditionally.#1621

Merged
rwgk merged 1 commit intoNVIDIA:mainfrom
rwgk:remove_info_lines_presence_requirement
Feb 14, 2026
Merged

Make pathfinder INFO line counting non-failing unconditionally.#1621
rwgk merged 1 commit intoNVIDIA:mainfrom
rwgk:remove_info_lines_presence_requirement

Conversation

@rwgk
Copy link
Collaborator

@rwgk rwgk commented Feb 13, 2026

This resolves failures in the nightly testing.

Super-simple alternative to to #1592 and #1593

The INFO lines are very valuable in the unique situation that pathfinder is in: the behavior is by design highly dependent on the environment setup. Without the INFO lines, we have no way of validating what the behavior is in the GHA jobs.

The fraction of INFO lines in a typical CI log file is around 2.5%:

rwgk-win11.localdomain:~/wrk/logs_21965469504 $ wc -l Test_linux-aarch64___py3.11__12.9.1__wheels__a100.txt
5596 Test_linux-aarch64___py3.11__12.9.1__wheels__a100.txt
rwgk-win11.localdomain:~/wrk/logs_21965469504 $ grep 'Z INFO' Test_linux-aarch64___py3.11__12.9.1__wheels__a100.txt | wc -l
140

In interactive use, the INFO lines are shown only if the pytest -v option is specified. In that case, the fraction of INFO lines in the combined pathfinder, bindings, core test outputs is also around 2%, e.g.:

smc120-0009.ipp2a2.colossus.nvidia.com:/wrk/logs $ wc -l cuda-python_qa_bindings_linux_2026-01-07+142305_tests_log.txt
3199 cuda-python_qa_bindings_linux_2026-01-07+142305_tests_log.txt
smc120-0009.ipp2a2.colossus.nvidia.com:/wrk/logs $ grep -a '^INFO ' cuda-python_qa_bindings_linux_2026-01-07+142305_tests_log.txt | wc -l
55

(The exact fraction here is 1.7%, but the log file includes some other things, like nvidia-smi, pip list.)

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Feb 13, 2026

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk
Copy link
Collaborator Author

rwgk commented Feb 13, 2026

/ok to test

@github-actions

This comment has been minimized.

@cpcloud
Copy link
Contributor

cpcloud commented Feb 13, 2026

I made #1593 for a reason. It's a huge nuisance for the common case of an initial "what went wrong here" workflow to have bunch of log spam in CI. It wasn't designed to solve the nightly problem, it was designed to solve another problem, so it's not an alternative to anything.

@cpcloud
Copy link
Contributor

cpcloud commented Feb 13, 2026

Using standard logging facilities instead of what I would consider a weird list appending function is also just easier to follow IMO.

@cpcloud
Copy link
Contributor

cpcloud commented Feb 13, 2026

Again, I'm not trying to remove the INFO lines, I'm trying to make the common CI debugging case less spammy, and keep the INFO lines around for any subsequent deeper dives.

@rwgk
Copy link
Collaborator Author

rwgk commented Feb 13, 2026

Again, I'm not trying to remove the INFO lines, I'm trying to make the common CI debugging case less spammy, and keep the INFO lines around for any subsequent deeper dives.

Can we please keep the INFO mechanism as is for now and go with this easy solution that unblocks you?

The other PRs are different, but not simplifications.

The separate file has a bunch of pitfalls and I'd have to make adjustments elsewhere (e.g. extra steps to get them into ctk-next qa logs). I'd appreciate if we don't have to tear up the road for the small issue you stumbled over.

@rwgk
Copy link
Collaborator Author

rwgk commented Feb 13, 2026

@rwgk rwgk merged commit 463ed53 into NVIDIA:main Feb 14, 2026
167 of 169 checks passed
@rwgk rwgk deleted the remove_info_lines_presence_requirement branch February 14, 2026 01:43
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants