Make pathfinder INFO line counting non-failing unconditionally.#1621
Make pathfinder INFO line counting non-failing unconditionally.#1621rwgk merged 1 commit intoNVIDIA:mainfrom
INFO line counting non-failing unconditionally.#1621Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
I made #1593 for a reason. It's a huge nuisance for the common case of an initial "what went wrong here" workflow to have bunch of log spam in CI. It wasn't designed to solve the nightly problem, it was designed to solve another problem, so it's not an alternative to anything. |
|
Using standard logging facilities instead of what I would consider a weird list appending function is also just easier to follow IMO. |
|
Again, I'm not trying to remove the INFO lines, I'm trying to make the common CI debugging case less spammy, and keep the INFO lines around for any subsequent deeper dives. |
Can we please keep the INFO mechanism as is for now and go with this easy solution that unblocks you? The other PRs are different, but not simplifications. The separate file has a bunch of pitfalls and I'd have to make adjustments elsewhere (e.g. extra steps to get them into ctk-next qa logs). I'd appreciate if we don't have to tear up the road for the small issue you stumbled over. |
|
There was a known flake: https://github.com/NVIDIA/cuda-python/actions/runs/21995912807/job/63556542405?pr=1621 Tracked now under #1622 |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
This resolves failures in the nightly testing.
Super-simple alternative to to #1592 and #1593
The
INFOlines are very valuable in the unique situation that pathfinder is in: the behavior is by design highly dependent on the environment setup. Without theINFOlines, we have no way of validating what the behavior is in the GHA jobs.The fraction of
INFOlines in a typical CI log file is around 2.5%:In interactive use, the
INFOlines are shown only if thepytest -voption is specified. In that case, the fraction ofINFOlines in the combined pathfinder, bindings, core test outputs is also around 2%, e.g.:(The exact fraction here is 1.7%, but the log file includes some other things, like
nvidia-smi,pip list.)