fix(cluster): preserve gateway image transport mode#717
Closed
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep
tasks/scripts/cluster-deploy-fast.shaligned with the active gateway image transport mode instead of defaulting to127.0.0.1:5000/openshell.Related Issue
N/A
Changes
openshell/gateway:devdirectly into k3s containerd when the cluster is using local image import modeTesting
mise run pre-commitpassesNotes:
mise run clustersucceeded locally after the fix, including the fast-deploy path.mise run pre-commitdoes not pass cleanly in this environment becausepython:protois missinggrpc_tools, one integration test expects port8080to be free, and repo-wide Clippy warnings are currently failing the task.Checklist