fix: handle ingestion errors and cursor advancement on message deletion#42
Open
fix: handle ingestion errors and cursor advancement on message deletion#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When messages were deleted in realtime, the cursor was not updated, causing permanent data loss when the bot restarted.
Problem
Cursor points to message D (ID 1005)
D is deleted in realtime → message removed from Qdrant, but cursor still points to 1005
Bot goes offline
Messages E, F, G sent offline (IDs 1011, 1012, 1013)
Bot restarts → audit finds cursor 1005 doesn't exist → jumps to most recent (1013) → skips 1011, 1012, 1013 permanently
Solution
In
handle_message_delete, when the deleted message is the cursor, fetch the most recent remaining message from Discord and advance the cursor to it immediately, preventing stale cursor state that would cause audit to skip messages on restart.Files Changed
src/core/discord_listener.py- Added cursor update logic when cursor message is deletedtests/unit/test_discord_listener.py- Added tests for the deletion cursor handling