Draft
Conversation
The very beginning of a checkers module! Includes *some* backend (just enough to proof-of-concept run it) and *some* terminal features (ditto on the "just enough"). Still needs double-jump, "king-ing", a check to prevent un-king-ed pieces from moving backwards (so maybe king-ing DOESN'T need to be added? 🤔) end-of-game winner messages, option for obligatory jumping... I'm sure I'll think of more. This commit is mostly meant to allow @MicahWW to give input and suggest changes while this is still in the relatively early stages. I suspect the col,row format will be a contentious discussion, I do already have ideas for where an earlier switch-around for those could go, but we'll pin down the details. Other talking points include: - player numbering (zero-indexing players in TicTacToe is fine but for Checkers this is a hill I will die on) - the placement of jumpPiece in checkValidMove (I don't love it, open to conversation) - the colors of pieces - if out-of-bounds spaces should be colored differently than in-bounds spaces (that would take a bit of doing and would be good to start discussing now) - invalidEntryMessage as basically a variable/constant Lastly... can I do a Batman titles thing for the next two commits on this topic? So my next one would be "Checkers - Dark Knight" or something like that
Shut up, flake8
Shut up, flake8
Collaborator
Author
|
I tried to comment/document heavily to make it as clear as possible what's going on in each line. I should be free tomorrow to do a voice chat if you want a sherpa through the whole thing as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The very beginning of a checkers module! Includes some backend (just enough to proof-of-concept run it) and some terminal features (ditto on the "just enough").
Still needs double-jump, "king-ing", a check to prevent un-king-ed pieces from moving backwards (so maybe king-ing DOESN'T need to be added? 🤔) end-of-game winner messages, option for obligatory jumping... I'm sure I'll think of more.
This commit is mostly meant to allow @MicahWW to give input and suggest changes while this is still in the relatively early stages. I suspect the col,row format will be a contentious discussion, I do already have ideas for where an earlier switch-around for those could go, but we'll pin down the details. Other talking points include:
Lastly... can I do a Batman titles thing for the next two commits on this topic? So my next one would be "Checkers - Dark Knight" or something like that