feat: migrate to @metamask/messenger-cli for action types codegen

[cryptodev-2s]

Description

Migrates from the deprecated messenger-generate-action-types binary in @metamask/messenger to the new standalone @metamask/messenger-cli package.

• Add @metamask/messenger-cli@^0.1.0 as devDependency
• Add messenger-action-types:generate script (generates action type files, scans app/, runs prettier)
• Add messenger-action-types:check script (generates and verifies no diff)
• Integrate into lint and lint:fix
• Remove old generate-method-action-types scripts

Changelog

CHANGELOG entry: null

Related issues

Related to MetaMask/core#8378

Manual testing steps

Feature: messenger action types codegen

  Scenario: developer generates action types
    Given the project has controllers with MESSENGER_EXPOSED_METHODS

    When developer runs yarn messenger-action-types:generate
    Then action type files are generated for all controllers

  Scenario: developer checks action types are up to date
    Given the project has controllers with MESSENGER_EXPOSED_METHODS

    When developer runs yarn messenger-action-types:check
    Then the check passes if files are up to date

Screenshots/Recordings

N/A — developer tooling change, no UI impact.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

---

Note

Low Risk
Low risk developer-tooling change that updates action-type codegen commands and lint wiring; main risk is CI/lint failures if the new CLI’s output differs or the check script behavior changes.

Overview
Migrates messenger action-types code generation from the deprecated messenger-generate-action-types binary to the new @metamask/messenger-cli.

Updates lint/lint:fix to run the new messenger-action-types:check/messenger-action-types:generate scripts, removes the old generate-method-action-types* scripts, and adds @metamask/messenger-cli@^0.1.0 to dependencies (with corresponding yarn.lock updates).

^{Reviewed by Cursor Bugbot for commit 0708534. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​metamask/​messenger-cli@​0.1.0

View full report

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

✅ E2E Fixture Validation — Schema is up to date
18 value mismatches detected (expected — fixture represents an existing user).
View details

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 046008c. Configure here.}

[cursor]

Semicolon silently ignores generation failure in check script

High Severity

The messenger-action-types:check script uses a semicolon (;) instead of && after the messenger-action-types --generate app command. This means if the generation step fails (non-zero exit), the error is silently ignored, and the script continues to run prettier and git diff --exit-code. Since no files changed (generation failed), git diff --exit-code passes, making the overall lint command succeed even though codegen is broken. The :generate script correctly uses &&, so this inconsistency appears unintentional.

 

^{Reviewed by Cursor Bugbot for commit 046008c. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: None (no tests recommended)
• Selected Performance tags: None (no tests recommended)
• Risk Level: low
• AI Confidence: 97%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes in this PR are purely developer tooling changes with no runtime impact:

1. package.json script renaming: The generate-method-action-types and generate-method-action-types:check scripts were renamed to messenger-action-types:generate and messenger-action-types:check. The lint and lint:fix scripts were updated to reference the new names. These are development-time scripts only.

2. New devDependency: @metamask/messenger-cli@^0.1.0 was added as a devDependency. This is a CLI tool used only during development for generating TypeScript messenger action types. It has no runtime presence in the app bundle.

3. yarn.lock: Updated to include the lockfile entry for the new devDependency.

None of these changes affect:

• Application runtime code or behavior
• Any user-facing features or flows
• E2E test scenarios
• App performance
• Controllers, Engine, or core architecture
• Navigation, modals, confirmations, or any shared components

No E2E tests need to run for these purely tooling/DX changes.

Performance Test Selection:
The changes are purely developer tooling (script renaming and a new devDependency CLI tool). There is no runtime code change, no UI component change, no state management change, and no performance-sensitive code path affected. No performance tests are needed.

View GitHub Actions results