[COR-923] Register missing metrics with controller-runtime registry#595
Draft
eddiebarth1 wants to merge 1 commit intomainfrom
Draft
[COR-923] Register missing metrics with controller-runtime registry#595eddiebarth1 wants to merge 1 commit intomainfrom
eddiebarth1 wants to merge 1 commit intomainfrom
Conversation
revisionFailedGauge and mirrorFailureCounter were only registered via promauto (global Prometheus registry) but not with the controller-runtime metrics.Registry, so they were absent from the /metrics endpoint. COR-923 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revisionFailedGauge(picchu_revision_failed) andmirrorFailureCounter(picchu_mirror_failure_counter) were only registered viapromauto(global Prometheus registry) but not with the controller-runtimemetrics.Registry/metricsfrom its own registry, these two metrics were absent from the endpointmetrics.Registry.MustRegister()call inRevisionReconciler.SetupWithManager()to match the pattern already used inReleaseManagerReconciler.SetupWithManager()Test plan
go build ./...)go vetpassespicchu_revision_failedandpicchu_mirror_failure_counterappear at:8383/metricsCompanion PR in mono: will link after creation
🤖 Generated with Claude Code