CMake: Version compatibility fixes 2#194
Merged
JeromeMartinez merged 1 commit intoMediaArea:masterfrom Mar 13, 2026
Merged
Conversation
Contributor
Author
|
@JeromeMartinez Actually the ZenLib CMake project still supports CMake 3.1. It can be configured by both CMake 3.1 and 4.x without any version warnings. Instead of bumping minimum to 3.5 previously, just adding a max supported version like we have now is enough to remove any warnings and errors in newer CMake. |
Member
|
Even RHEL 7 has CMake 3.6 and we don't support it anymore.Our oldest supported platform is RHEL 8 and it has CMake 3.11 minimum, and updated RHEL 8.4 has CMake 3.18+.So actually I could afford a higher CMake version.For me minimum of 3.5 is totally fine, I suggest to keep it (or 3.8?) if there is no strong need/wish of it on your side.
|
Contributor
Author
Let's keep it then. I don't really use the CMake (mainly just for developing the official Android app and if I ever need to self build on Linux) and when I do I always use latest pre-installed by build tools which is very new. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.