Move T35 parsing code to its own parser#2541
Move T35 parsing code to its own parser#2541JeromeMartinez wants to merge 1 commit intoMediaArea:masterfrom
Conversation
|
Mistake in MSVC2022 Project? It became copy of 2026 one. I just noticed there is inconsistency for |
|
I have pushed an update, project files should be fixed.
I should not change anything about that, if there an issue with that, it would deserve a dedicated PR. |
I am not sure what that is supposed to be. Is it supposed to use precompiled header for MSVC? Right now I see it is disabled for x64, Debug and enabled for the rest while the PreComp.h became useless in 2017 due to commenting out: d40d86f#diff-35284cb4d3703d3abb0969c5e1f8899722e1ee7ac4d355487c69807e70e41b78 |
Mistake, I think.
Would be a bug, please open a dedicated PR as it is not related to this PR. |
There is also another inconsistency which causes compilation to fail for x64, Debug when precomp is enabled. Wow, compilation is super fast with precomp enabled. So all these years wasted all those compile time due to this bug? I'll make a PR with the fixes. |
Same! I was sure I was using it and I was disliking the slow speed despite precompiled header, argh now I see that I introduced a mistake there... |
|
I see that there used to be wholeprogramoptimization enabled and warning level set to level 4 and was removed in 11139e6 |
I suggest to only use C++ style cast for pointers. Static analyzers will flag C-style casts when used on pointers as they can potentially result in unintended dangerous casts. Ah, that macro issues with different compilers expanding macros differently. I ran into that when re-writing the XMP parser. |
I'll remove them soon, so I won't have to deal with compilers expanding differently that. |
No description provided.