fix: enable Shift+Click text selection#1548
Open
lustsazeus-lab wants to merge 1 commit intoMatterHackers:mainfrom
Open
fix: enable Shift+Click text selection#1548lustsazeus-lab wants to merge 1 commit intoMatterHackers:mainfrom
lustsazeus-lab wants to merge 1 commit intoMatterHackers:mainfrom
Conversation
When Shift is held during mouse click, the Selecting flag was not being set to true, preventing the selection from being created. This fix adds Setting Selecting = true when Shift+Click occurs, allowing users to select a range of text by clicking at the start position, then Shift+clicking at the end position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Shift is held during mouse click in text fields, the
Selectingflag was not being set to true, preventing text selection from being created.Fix
Added logic to set
Selecting = truewhen Shift+Click occurs, allowing users to select a range of text by:This matches the expected behavior documented in the existing test
TextSelectionWithShiftClick.Changes
Gui/TextWidgets/InternalTextEditWidget.cs: Added else branch to setSelecting = truewhen Shift key is held during mouse down event.Testing
The existing test
TextSelectionWithShiftClickinTests/Agg.Tests/Agg Automation Tests/TextEditTests.csvalidates this functionality.Closes #1411