#478: dependencies updated to 2026-03-30#479
Conversation
Summary by CodeRabbit
WalkthroughThe package manifest version was incremented from 0.1.2 to 0.1.4, accompanied by a new npm version script. Dependency versions were updated for react-router-dom, Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 20: The "version" npm script currently runs "npm version $VERSION
--no-git-tag-version", which triggers npm's version lifecycle recursively;
rename the script key (e.g., from "version" to "set-version" or
"update-version") and update any callers to use the new script name so you no
longer collide with npm's built-in version lifecycle hook; ensure the script
value remains "npm version $VERSION --no-git-tag-version" (or call the
underlying versioning command directly) and update CI/README references that
invoke the old "version" script.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3f4d1f63-a914-48e5-8859-73143a71f1fb
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json
| "compile-social": "tsc -p src/apps/social --noEmit", | ||
| "preview": "vite preview", | ||
|
|
||
| "version": "npm version $VERSION --no-git-tag-version", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "scripts.version:"
jq -r '.scripts.version // "<missing>"' package.json
echo
if jq -r '.scripts.version // ""' package.json | grep -Eq '\bnpm[[:space:]]+version\b'; then
echo "Potential recursion risk: scripts.version invokes 'npm version'."
else
echo "No self-invocation pattern detected."
fiRepository: MaskingTechnology/comify
Length of output: 192
Avoid recursive npm version invocation in the version lifecycle script.
The version script at line 20 invokes npm version, creating a recursion risk. When npm version runs, it triggers the version lifecycle script, which re-invokes npm version recursively. Rename the script to avoid the npm lifecycle hook collision.
Proposed fix
- "version": "npm version $VERSION --no-git-tag-version",
+ "set-version": "npm version $VERSION --no-git-tag-version",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "version": "npm version $VERSION --no-git-tag-version", | |
| "set-version": "npm version $VERSION --no-git-tag-version", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package.json` at line 20, The "version" npm script currently runs "npm
version $VERSION --no-git-tag-version", which triggers npm's version lifecycle
recursively; rename the script key (e.g., from "version" to "set-version" or
"update-version") and update any callers to use the new script name so you no
longer collide with npm's built-in version lifecycle hook; ensure the script
value remains "npm version $VERSION --no-git-tag-version" (or call the
underlying versioning command directly) and update CI/README references that
invoke the old "version" script.



Fixes #478
Changes proposed in this pull request:
@MaskingTechnology/comify