Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates small UI behaviors around the editor’s find/replace panels to better match macOS Tahoe’s “modern” styling, including button bezel style tweaks and titlebar-divider/layout adjustments.
Changes:
- Switch the Find panel “Done” button bezel style based on
AppDesign.modernStyle. - Move the find-panel layer reordering logic into
layoutPanels()to keep the visual stacking correct. - Simplify initial modern divider setup and switch to manual positioning during panel layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MarkEditMac/Sources/Panels/Find/EditorFindPanel.swift | Uses a different bezel style for the Done button when modernStyle is enabled. |
| MarkEditMac/Sources/Editor/Controllers/EditorViewController+UI.swift | Adjusts panel/layer ordering and manually positions the modern titlebar divider during layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MarkEditMac/Sources/Editor/Controllers/EditorViewController+UI.swift
Outdated
Show resolved
Hide resolved
cyanzhong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.