Skip to content

refactor: comprehensive SIAC codebase revision with docs#39

Merged
MarcYin merged 1 commit intofeat/refactorfrom
claude/zealous-gauss
Apr 2, 2026
Merged

refactor: comprehensive SIAC codebase revision with docs#39
MarcYin merged 1 commit intofeat/refactorfrom
claude/zealous-gauss

Conversation

@MarcYin
Copy link
Copy Markdown
Owner

@MarcYin MarcYin commented Apr 2, 2026

Summary

  • Deduplicate resampling: Extract canonical geo/resample.py module, eliminating ~470 lines of 3-way duplication across pipeline, corrector, and assembly
  • Fix alpha/band_weight_power: Thread algorithms.solver.alpha through MultiGridConfigCostFunctionConfig so the user's configured value is no longer silently ignored (default aligned to -1.6)
  • Performance & correctness: Vectorize Laplacian boundary construction, pre-allocate solver DataArrays to avoid per-iteration allocation, wrap RAA to [0, 2π), add division-by-zero guard in apply_correction
  • Simplify internals: Dict-based lazy imports in __init__.py, _ConfigShortcutsMixin to deduplicate ~12 config properties, keyword-arg grid assembler interface replacing fragile inspect.signature dispatch, remove empty Resolved* subclasses
  • Documentation: Update 9 doc files — add geo/resample.py to architecture, expand glossary with solver terms (DCT, multi-grid, RAA, RTModelBackend), document cost function and multi-grid strategy, annotate solver config fields, add RTModelBackend protocol and resampling utilities to developer guide

Test plan

  • pixi run lint passes
  • pixi run test-fast unit tests pass
  • pixi run test full suite including integration tests passes
  • mkdocs build --strict docs build passes
  • CI checks pass on this PR

🤖 Generated with Claude Code

Add geo/resample.py to package tree and architecture docs, expand
glossary with solver terms (DCT, multi-grid, RAA, RTModelBackend,
band_weight_power), document cost function and multi-grid strategy in
theory.md, annotate solver config fields, and add RTModelBackend
protocol and resampling utilities to the developer guide.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@MarcYin MarcYin merged commit 863abd9 into feat/refactor Apr 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant