refactor: comprehensive SIAC codebase revision with docs#39
Merged
MarcYin merged 1 commit intofeat/refactorfrom Apr 2, 2026
Merged
refactor: comprehensive SIAC codebase revision with docs#39MarcYin merged 1 commit intofeat/refactorfrom
MarcYin merged 1 commit intofeat/refactorfrom
Conversation
Add geo/resample.py to package tree and architecture docs, expand glossary with solver terms (DCT, multi-grid, RAA, RTModelBackend, band_weight_power), document cost function and multi-grid strategy in theory.md, annotate solver config fields, and add RTModelBackend protocol and resampling utilities to the developer guide. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
geo/resample.pymodule, eliminating ~470 lines of 3-way duplication across pipeline, corrector, and assemblyalgorithms.solver.alphathroughMultiGridConfig→CostFunctionConfigso the user's configured value is no longer silently ignored (default aligned to -1.6)apply_correction__init__.py,_ConfigShortcutsMixinto deduplicate ~12 config properties, keyword-arg grid assembler interface replacing fragileinspect.signaturedispatch, remove emptyResolved*subclassesgeo/resample.pyto architecture, expand glossary with solver terms (DCT, multi-grid, RAA, RTModelBackend), document cost function and multi-grid strategy, annotate solver config fields, add RTModelBackend protocol and resampling utilities to developer guideTest plan
pixi run lintpassespixi run test-fastunit tests passpixi run testfull suite including integration tests passesmkdocs build --strictdocs build passes🤖 Generated with Claude Code