Skip to content

ci: fix checks and ruleset configuration#6

Merged
leonardosul merged 2 commits intomainfrom
fix/ci-checks-and-rulesets
Feb 27, 2026
Merged

ci: fix checks and ruleset configuration#6
leonardosul merged 2 commits intomainfrom
fix/ci-checks-and-rulesets

Conversation

@leonardosul
Copy link
Contributor

Summary

  • Remove push: branches: [main] trigger from precommit.yml (pointless after merge)
  • Remove useless release-please if: skip conditions from all 3 workflows (GITHUB_TOKEN PRs don't trigger workflows — the conditions never evaluated)
  • Add Go Tests status badge to README (go-tests still runs on push to main)

Ruleset changes (applied via API)

  • Removed integration-test from required status checks
  • Removed OrganizationAdmin from bypass list
  • Changed RepositoryRole: Admin bypass from always to pull_request mode

How it works now

  • Regular PRs: precommit and go-test run and must pass
  • Release-please PRs: Checks don't trigger (GITHUB_TOKEN limitation); admin merges using PR bypass
  • Nobody can force push, delete main, or push directly — not even admins
  • Integration tests: Run on-demand via label, not required for merge

Test plan

  • Verify precommit and go-test run on this PR
  • Verify precommit does NOT run on merge to main
  • Verify admin can merge release-please PR chore(main): release 0.1.1 #5 via bypass

🤖 Generated with Claude Code

leonardosul and others added 2 commits February 27, 2026 10:00
- Remove push-to-main trigger from precommit (pointless after merge)
- Remove useless release-please skip conditions from all workflows
  (GITHUB_TOKEN PRs don't trigger workflows anyway)
- Remove integration-test from required checks (via API)
- Remove OrganizationAdmin bypass, narrow admin to pull_request mode
- Add Go Tests badge to README

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@leonardosul leonardosul merged commit 65fb893 into main Feb 27, 2026
2 checks passed
@leonardosul leonardosul deleted the fix/ci-checks-and-rulesets branch February 27, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant