Remove drop level gap condition for jewels#697
Draft
ze-dom wants to merge 2 commits intoMUnique:masterfrom
Draft
Remove drop level gap condition for jewels#697ze-dom wants to merge 2 commits intoMUnique:masterfrom
ze-dom wants to merge 2 commits intoMUnique:masterfrom
Conversation
ze-dom
commented
Feb 19, 2026
Comment on lines
+442
to
+446
| if (monsterLevel > 66) | ||
| { | ||
| // Jewel of Chaos doesn't drop after a certain monster level | ||
| filteredPossibleItems.RemoveAll(it => it.Group == 12 && it.Number == 15); | ||
| } |
ze-dom
commented
Feb 19, 2026
| } | ||
| else | ||
| { | ||
| filteredPossibleItems = [.. selectedGroup.PossibleItems.Where(it => it.DropLevel == 0 || (it.DropLevel <= monsterLevel && it.DropLevel > monsterLevel - 12))]; |
ze-dom
commented
Feb 19, 2026
Comment on lines
+32
to
+37
| var angel = this.CreatePet(0, "Guardian Angel", 23, (Stats.DamageReceiveDecrement, 0.8f, AggregateType.Multiplicate), (Stats.MaximumHealth, 50f, AggregateType.AddRaw)); | ||
| this.AddItemToJewelItemDrop(angel); | ||
| var imp = this.CreatePet(1, "Imp", 28, (Stats.AttackDamageIncrease, 1.3f, AggregateType.Multiplicate)); | ||
| this.AddItemToJewelItemDrop(imp); | ||
| var uniria = this.CreatePet(2, "Horn of Uniria", 25); | ||
| this.AddItemToJewelItemDrop(uniria); |
ze-dom
commented
Feb 19, 2026
| alcohol.Height = 2; | ||
| alcohol.SetGuid(alcohol.Group, alcohol.Number); | ||
| alcohol.ConsumeEffect = this.GameConfiguration.MagicEffects.First(effect => effect.Number == (short)MagicEffectNumber.Alcohol); | ||
| this.AddItemToJewelItemDrop(alcohol); |
ze-dom
commented
Feb 19, 2026
| definition.Width = 1; | ||
| definition.Height = 2; | ||
| definition.SetGuid(definition.Group, definition.Number); | ||
| this.AddItemToJewelItemDrop(definition); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo
This fix removes the drop level gap condition for Jewels, Imp, Angel, Uniria, Ale, and Town Portal Scroll, which was preventing these items from dropping by mobs with higher levels than that limit.
Remarks
Let me know your opinion on the following points, as to whether we should add them or not:
Apparently in zTeamS6.3, they moved the jewel item checks somewhere else and mobs didn't drop them. Maybe they sold them in NPC stores or something.