Fix build on Apple Silicon (ARM64) by updating config.sub/guess#15
Open
Hayyim-H wants to merge 1 commit intoMP-Gadget:masterfrom
Open
Fix build on Apple Silicon (ARM64) by updating config.sub/guess#15Hayyim-H wants to merge 1 commit intoMP-Gadget:masterfrom
Hayyim-H wants to merge 1 commit intoMP-Gadget:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a build issue that occurs on modern macOS machines with Apple Silicon (M1/M2/M3/M4 chips).
Currently, when
piporsetup.pyattempts to build the package on anarm64-applearchitecture, the embedded configuration files inside the downloadedpfftandfftw3tarball are too old to recognize the ARM64 architecture, resulting in the following fatal error:Invalid configuration 'arm64-apple-darwin': machine 'arm64-apple' not recognizedChanges Made
Added a few lines in
depends/install_pfft.shright after the tarball is extracted. It downloads the latestconfig.subandconfig.guessdirectly from the official GCC mirror and replaces the outdated ones in both thepfftroot and the embeddedfftw3directory.This allows the
./configurestep to successfully identify the architecture and compile the C code without issues.