Skip to content

Remove Vundle#30

Merged
ShawnConn merged 3 commits intomainfrom
rm-vundle
Dec 14, 2025
Merged

Remove Vundle#30
ShawnConn merged 3 commits intomainfrom
rm-vundle

Conversation

@ShawnConn
Copy link
Copy Markdown
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @ShawnConn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant breaking change by fully deprecating and removing the Vundle Vim plugin manager from the project's setup. This involves updating various configuration files to reflect the new plugin management approach and removing all Vundle-specific Ansible roles and tasks. Additionally, a minor update to the default macOS Tart image name has been included in the common scripts.

Highlights

  • Vundle Removal: The Vundle Vim plugin manager has been completely removed from the project, including its configuration files and associated Ansible roles.
  • Vim Plugin Configuration Update: Configuration files (.mini.config.yml, .most.config.yml, default.config.yml, and their Docker counterparts) have been updated to remove references to .vundle.vimrc and introduce .plugins.vimrc, indicating a shift in Vim plugin management.
  • Ansible Role Deprecation: The nass600.vundle Ansible role has been removed from both Linux and macOS initialization and configuration playbooks.
  • macOS Tart Image Update: The default macOS Tart image name in scripts/_common has been updated from 'sonoma-vanilla' to 'tahoe-vanilla'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on removing Vundle, and the changes largely accomplish this goal by updating various configuration files. I've noted a couple of areas for improvement: a duplicate entry in a YAML file and a change that seems out of scope for this PR's stated purpose. Addressing these points will help maintain the repository's cleanliness and history. Additionally, filling out the pull request description would provide valuable context for reviewers.

- .vimrc
- .vundle.vimrc
- .zshrc
- .plugins.vimrc
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The file .plugins.vimrc is duplicated in this list. It was already added on line 34. Please remove this duplicate entry.

ENVSETUP_DIR="$(dirname "$(dirname "$(realpath "$0")")")"
INSTALL_DIR=${ENVSETUP_INSTALL_DIR:-"$ENVSETUP_DIR"}
TART_MACOS_NAME=${TART_MACOS_NAME:-"sonoma-vanilla"}
TART_MACOS_NAME=${TART_MACOS_NAME:-"tahoe-vanilla"}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change to TART_MACOS_NAME seems unrelated to the pull request's goal of removing Vundle. To keep commits atomic and focused, it's best to move unrelated changes to a separate pull request.

TART_MACOS_NAME=${TART_MACOS_NAME:-"sonoma-vanilla"}

@ShawnConn ShawnConn merged commit c3c380a into main Dec 14, 2025
9 checks passed
@ShawnConn ShawnConn deleted the rm-vundle branch December 14, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant