Skip to content

fix: sparse Array usage in Array.extend#7315

Merged
Rathoz merged 9 commits intomainfrom
sparse-array-in-extend
Mar 31, 2026
Merged

fix: sparse Array usage in Array.extend#7315
Rathoz merged 9 commits intomainfrom
sparse-array-in-extend

Conversation

@hjpalpha
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha commented Mar 28, 2026

Summary

How did you test this change?

dev

@hjpalpha hjpalpha marked this pull request as ready for review March 28, 2026 14:29
@hjpalpha hjpalpha requested review from a team as code owners March 28, 2026 14:29
Copy link
Copy Markdown
Collaborator

@mbergen mbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides comment

@hjpalpha hjpalpha requested a review from mbergen March 29, 2026 12:34
@hjpalpha hjpalpha requested a review from mbergen March 29, 2026 13:04
Copy link
Copy Markdown
Collaborator

@ElectricalBoy ElectricalBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic.readBool(args.hasDate) and {
INDENT .. '|date=',
INDENT .. '|twitch= |youtube=',
(Logic.readBool(args.reddit) and INDENT .. '|reddit= |gol=' or nil),
INDENT .. '|mvp='
} or nil,

would also need to fix sparse array here too

@Rathoz Rathoz merged commit 08dde11 into main Mar 31, 2026
7 checks passed
@Rathoz Rathoz deleted the sparse-array-in-extend branch March 31, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants