Skip to content

feat(standings): use new table design in swiss standings#7294

Open
ElectricalBoy wants to merge 15 commits intomainfrom
swiss-standings-use-label
Open

feat(standings): use new table design in swiss standings#7294
ElectricalBoy wants to merge 15 commits intomainfrom
swiss-standings-use-label

Conversation

@ElectricalBoy
Copy link
Copy Markdown
Collaborator

@ElectricalBoy ElectricalBoy commented Mar 23, 2026 •
edited
Loading

Summary

Depends on #7256

How did you test this change?

https://liquipedia.net/leagueoflegends/User:ElectricalBoy/Sandbox + browser dev tools

image image

@ElectricalBoy ElectricalBoy requested review from a team as code owners March 23, 2026 11:31
@ElectricalBoy ElectricalBoy added c: standings stylesheets Changes to stylesheets javascript Changes to JavaScript files labels Mar 23, 2026
@ElectricalBoy ElectricalBoy changed the base branch from main to veto-labels March 23, 2026 11:32
hjpalpha
hjpalpha reviewed Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't they get an overhaul soon anyways

@ElectricalBoy ElectricalBoy force-pushed the swiss-standings-use-label branch from 0574474 to e85554b Compare March 24, 2026 01:56
Base automatically changed from veto-labels to main March 25, 2026 08:25
@ElectricalBoy ElectricalBoy force-pushed the swiss-standings-use-label branch from e85554b to ca6c46c Compare March 25, 2026 09:28
@ElectricalBoy
Copy link
Copy Markdown
Collaborator Author

ElectricalBoy commented Mar 25, 2026

don't they get an overhaul soon anyways

this basically is the first baby step of that overhaul

@ElectricalBoy ElectricalBoy requested a review from hjpalpha March 25, 2026 09:39
Rathoz
Rathoz reviewed Mar 25, 2026
View reviewed changes
Rathoz
Rathoz reviewed Mar 25, 2026
View reviewed changes
Rathoz
Rathoz reviewed Mar 25, 2026
View reviewed changes
@ElectricalBoy ElectricalBoy requested a review from Rathoz March 26, 2026 00:23
Eetwalt
Eetwalt reviewed Mar 26, 2026
View reviewed changes
@ElectricalBoy ElectricalBoy requested a review from Eetwalt March 26, 2026 12:39
hjpalpha
hjpalpha reviewed Mar 27, 2026
View reviewed changes
@ElectricalBoy ElectricalBoy requested a review from hjpalpha March 27, 2026 05:24
hjpalpha
hjpalpha approved these changes Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

Rathoz
Rathoz reviewed Mar 30, 2026
View reviewed changes
stylelint.config.mjs
"no-duplicate-selectors": null,
"function-url-no-scheme-relative": null,
"declaration-no-important": null,
"function-disallowed-list": [],
Copy link
Copy Markdown
Collaborator

@Rathoz Rathoz Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this needed for?

Copy link
Copy Markdown
Collaborator Author

@ElectricalBoy ElectricalBoy Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/wikimedia/stylelint-config-wikimedia/blob/08934531b98deaeae5965ff271174a08f87ad50a/index.js#L93

Lua-Modules/stylesheets/commons/Label.scss

Line 134 in 383fe86

background-color: rgb( from var( --placement-solid-color ) r g b / 0.08 );

wikimedia config has rgb() in disallowed list, but this PR needs it for relative colors

Copy link
Copy Markdown
Collaborator

@Rathoz Rathoz Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elysienna what's your opinion?

Copy link
Copy Markdown
Contributor

@liquidely liquidely Mar 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why wikimedia disallows this. Maybe you can try hsl()? If not then should be fine to change the config

Copy link
Copy Markdown
Collaborator Author

@ElectricalBoy ElectricalBoy Mar 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hsl() should work fine as we only need to modify the alpha channel
though I think it makes more (logical) sense to keep rgb() as the rest of stylesheets use RGB colors

@ElectricalBoy ElectricalBoy requested a review from Rathoz March 30, 2026 08:02
liquidely
liquidely reviewed Mar 30, 2026
View reviewed changes
liquidely
liquidely reviewed Mar 30, 2026
View reviewed changes
@ElectricalBoy ElectricalBoy requested a review from liquidely March 31, 2026 00:09
@ElectricalBoy ElectricalBoy force-pushed the swiss-standings-use-label branch from bfa3ad2 to 90a1d3a Compare March 31, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbergen mbergen mbergen left review comments

@hjpalpha hjpalpha hjpalpha approved these changes

@Eetwalt Eetwalt Awaiting requested review from Eetwalt

@Rathoz Rathoz Awaiting requested review from Rathoz

@liquidely liquidely Awaiting requested review from liquidely

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c: standings javascript Changes to JavaScript files stylesheets Changes to stylesheets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ElectricalBoy @Rathoz @mbergen @hjpalpha @Eetwalt @liquidely