[PTDT-4832] Prelabels for text subclasses under global text classes#2040
Merged
[PTDT-4832] Prelabels for text subclasses under global text classes#2040
Conversation
lb-mwetter
approved these changes
Jan 31, 2026
Jmsa
approved these changes
Jan 31, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| for annot in text.classifications | ||
| ] | ||
| if text.classifications | ||
| else None, |
There was a problem hiding this comment.
Missing serializer to remove empty classifications in NDText
Low Severity
NDText is missing the serialize_model method that NDChecklist and NDRadio have to remove empty classifications from serialized output. When NDText has classifications=[] (e.g., from deserializing ndjson with an empty list), it will serialize with "classifications": [], while NDChecklist and NDRadio would omit the key entirely. This creates inconsistent serialization behavior across classification types.
Additional Locations (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
text subclass prelabels are supported for global classes
Fixes # (issue)
Type of change
How to test
this script creates a prelabel
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features
Note
Medium Risk
Touches NDJSON (de)serialization for
Textclassifications by adding a new optional nestedclassificationsfield; incorrect mapping could break prelabel import/export for text classifications.Overview
Adds an optional
classificationsfield to theTextclassification answer model to support nested subclassifications.Updates NDJSON conversion for text classifications (
NDTextSubclass.to_common/from_commonandNDText.from_common) to round-trip these nestedclassificationsviaNDSubclassification, enabling prelabels for text subclasses.Written by Cursor Bugbot for commit c9bfc39. This will update automatically on new commits. Configure here.