Skip to content

GitHub Issue 875: Assay Multi-File Transform Import Skips First Data Row #7456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnathe merged 4 commits into from
Feb 27, 2026
Merged

GitHub Issue 875: Assay Multi-File Transform Import Skips First Data Row #7456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26a8aba
GitHub Issue #875: TsvDataSerializer.exportData() to write first row …
cnathe Feb 25, 2026
27c9858
GitHub Issue #875: TsvDataSerializer.exportData() to write first row …
cnathe Feb 25, 2026
8d49ed4
Experiment module metric (assayRunsWithMultipleInputFiles) for count …
cnathe Feb 26, 2026
f6fae29
minor update to SQL for assayRunsWithMultipleInputFiles
cnathe Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/org/labkey/api/qc/TsvDataSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ private List<String> exportData(DataIteratorBuilder data, List<String> columns,
sep = "\t";
}
pw.println();
writeRow(row, columns, pw, tsvWriter);
}
writeRow(row, columns, pw, tsvWriter); // GitHub Issue #875: write the first row regardless of whether we had a header or not

// write the remaining rows
while (iter.next())
Expand Down
11 changes: 11 additions & 0 deletions experiment/src/org/labkey/experiment/ExperimentModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,17 @@ SELECT COUNT(DISTINCT DD.DomainURI) FROM
JOIN exp.DomainDescriptor DD on PD.domainID = DD.domainId
WHERE DD.domainUri LIKE ? AND D.rangeURI = ?""", "urn:lsid:%:" + ExpProtocol.AssayDomainTypes.Result.getPrefix() + ".%", PropertyType.FILE_LINK.getTypeUri()).getObject(Long.class));

// metric to count the number of Luminex and Standard assay runs that were imported with > 1 data file
assayMetrics.put("assayRunsWithMultipleInputFiles", new SqlSelector(schema, """
SELECT COUNT(*) FROM (
SELECT sourceapplicationid, COUNT(*) AS count FROM exp.data
WHERE lsid NOT LIKE '%:RelatedFile.%' AND sourceapplicationid IN (
SELECT rowid FROM exp.protocolapplication
WHERE lsid LIKE '%:SimpleProtocol.CoreStep' AND (protocollsid LIKE '%:LuminexAssayProtocol.%' OR protocollsid LIKE '%:GeneralAssayProtocol.%')
)
GROUP BY sourceapplicationid
) x WHERE count > 1""").getObject(Long.class));

Map<String, Object> sampleLookupCountMetrics = new HashMap<>();
SQLFragment baseAssaySampleLookupSQL = new SQLFragment("SELECT COUNT(*) FROM exp.propertydescriptor WHERE (lookupschema = 'samples' OR (lookupschema = 'exp' AND lookupquery = 'Materials')) AND propertyuri LIKE ?");

Expand Down