Draft
Conversation
caiiiycuk
changed the title
Contributor
Author
|
Я пробавл передлеать на ErrH.Abort ну тогда приходится вводить зависиомть от xtcore (errorhandler) незнаю есть ли в этом смысл. |
lpenguin
reviewed
Feb 1, 2022
Contributor
lpenguin
left a comment
lpenguin
left a comment
There was a problem hiding this comment.
Could you change all printf with std::cout? I've marked several places
|
|
||
| if(it == _storage.end()){ | ||
| throw ResourceDoesNotExistsException (rid); | ||
| printf("Resource does not exists %d\n", rid); |
Contributor
There was a problem hiding this comment.
Better to use cout here, like
std::cout << "Resource does not exists " << rid << std::endl;`| gl_error = glGetError(); | ||
| if(gl_error != 0){ | ||
| throw CompositorException(std::string("glBindTexture error: ") + std::to_string(gl_error)); | ||
| printf("%s\n", (std::string("glBindTexture error: ") + std::to_string(gl_error)).c_str()); |
Contributor
There was a problem hiding this comment.
Replace with
std::cout << "glBindTexture error: " << gl_error << std::endl;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.