Remove string refs from input-number.tsx#3133
Open
nishasy wants to merge 2 commits intoremove-string-refs-4from
Open
Remove string refs from input-number.tsx#3133nishasy wants to merge 2 commits intoremove-string-refs-4from
nishasy wants to merge 2 commits intoremove-string-refs-4from
Conversation
One part of our modernization efort is removing string refs. Doing that in `input-number.tsx` here. Note: Most of this was written by Cursor/Claude Sonnet 4.5. Issue: https://khanacademy.atlassian.net/browse/LEMS-369 Test plan: `pnpm jest` Storybook - Check the numeric input widget in the editor demo - `/?path=/story/editors-editorpage--demo`
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
|
Size Change: +48 B (+0.01%) Total Size: 498 kB
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (9015423) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3133If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3133If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3133 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
One part of our modernization efort is removing string refs.
Doing that in
input-number.tsxhere.Note: Most of this was written by Cursor/Claude Sonnet 4.5.
Issue: https://khanacademy.atlassian.net/browse/LEMS-369
Test plan:
pnpm jestStorybook
/?path=/story/editors-editorpage--demo