Optimize UI updates of slicing panel#3735
Optimize UI updates of slicing panel#3735FliegendeWurst wants to merge 1 commit intoKeYProject:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3735 +/- ##
============================================
+ Coverage 47.98% 50.33% +2.34%
+ Complexity 16045 15900 -145
============================================
Files 1683 1597 -86
Lines 96046 91015 -5031
Branches 15388 14548 -840
============================================
- Hits 46091 45810 -281
+ Misses 44683 39999 -4684
+ Partials 5272 5206 -66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the PR and fast response! However, in my opinion it would be better to have as little RuleAppListeners as possible, since that obviously is a per-rule overhead. Also, I think it would make sense to have MacroFinish and ProofLoaded events/listeners in any case. |
|
I thought the In this case, the main workload is not to query the graph size of the slicing, rather to calculate the dependency at all. |
|
In the extension settings, there is an option "Always track dependencies". If it is not checked, the dependency graph will be created when needed later. |
Related Issue
This pull request resolves #3734.
Intended Change
Alternative: add a listener that listens for macro finish and proof loaded events. Though I think we can afford updating the UI twice a second.
Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.