Update flip timer for actual meaningful max#12
Open
JPK314 wants to merge 5 commits intoKaiyotech:mainfrom
Open
Update flip timer for actual meaningful max#12JPK314 wants to merge 5 commits intoKaiyotech:mainfrom
JPK314 wants to merge 5 commits intoKaiyotech:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might break models that trained on an old version of the obs builder. The flip timer now goes from 0 to 120 but is still normalized to be an obs value from 0 to 1, so the old 1 in the observer would now be 78/120 with the new observer builder.