Correct vertex data reading for Unity < 4 meshes#366
Open
dv1x3r wants to merge 1 commit intoK0lb3:masterfrom
Open
Correct vertex data reading for Unity < 4 meshes#366dv1x3r wants to merge 1 commit intoK0lb3:masterfrom
dv1x3r wants to merge 1 commit intoK0lb3:masterfrom
Conversation
fix: correct channelMask bit parsing in get_channels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed two issues in MeshHelper:
get_channels:bytearray(n)creates n zero bytes not a bit array.Just a different behaviour if number is passed as an argument :D
So I replaced it with bitwise comparison
channelMask & (1 << i)read_vertex_data: skip processing ifm_VertexCountorm_DataSizeis empty.For compressed meshes, the
m_VertexData.m_VertexCountis 0, andm_VertexData.m_DataSizeis empty.UnityPy caused a crash in
UnityPyBoost.unpack_vertexdataAssetStudio handles this gracefully because C#
Buffer.BlockCopysilently copies 0 bytes when data is empty.Sample: Login.unity3d.zip