This repository was archived by the owner on Sep 4, 2024. It is now read-only.
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=========================================
+ Coverage 89.32% 89.5% +0.17%
=========================================
Files 21 22 +1
Lines 356 362 +6
=========================================
+ Hits 318 324 +6
Misses 38 38
Continue to review full report at Codecov.
|
Member
|
You asked for a review but there is still the "do not merge" badge? What do you want me to do? (: |
Member
Author
|
I created the pull request but I need the review not now since it's still work in progress. That is why "do not merge". :) |
Member
|
OK, I will dismiss the review request (when I am on laptop) and you can request the review when you are actually done. |
timziebart
suggested changes
Mar 26, 2019
Member
timziebart
left a comment
There was a problem hiding this comment.
Please finish and then request the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.