refactor!: make Event an interface#175
Open
ThexXTURBOXx wants to merge 3 commits intoJonasWanke:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change!
As it stands, the
Eventclass cannot be used in conjunction withfreezed.In order to fix this, I had two options:
Eventa real interfaceIEvent(or whatever) that is now the real interface and use that instead across the codebaseSince 2. seems to be a rather huge refactor, I chose option 1.
Of course, since 2. may be non-breaking, I can change this PR accordingly, if needed/wanted.